Learn more about these different git repos.
Other Git URLs
In a pull request displaying the diffs the line numbers for each file start at 1, so there is no correspondence between this number and the actual line number.
Maybe it can be done like Github does it?
<img alt="Snimek_z_2016-02-09_09-45-57.png" src="/pagure/issue/raw/files/e97041070f47e9a30ae5b88e97138f10ca99359e351850e83fa688953f8165de-Snimek_z_2016-02-09_09-45-57.png" />
Yeah, having the diff line numbers here is pretty confusing. I have created a PR to hide them here: https://pagure.io/pagure/pull-request/813
although, ultimately the way we present diffs to the user needs to be redone before we can have a presentation similar to what is requested in this bug, but this PR is a cleanup until that can happen.
@pingou I have started to look at this so far I have the backend code doing the magic to get the new and old line number. There is still a few stuff to fix but below is how it looks like
@ryanlerch how do you think we should display the old and new line number ? Similar to github with the color of the diff ?
<img alt="Screenshot_from_2016-10-03_21-57-35.png" src="/pagure/issue/raw/files/6a985d27da204d1575c43523d36f8d037ff0c37e9d68f55054ccdad42afc5717-Screenshot_from_2016-10-03_21-57-35.png" />
we can now do this a lot easier with the use of diff2html. diffs for commits actually do this now in pagure 5.0
PR diffs currently are a bit harder, due to inline comments, so blocking on #3488
Metadata Update from @ryanlerch: - Issue marked as blocking: #3488
Metadata Update from @ryanlerch: - Issue unmarked as blocking: #3488 - Issue marked as blocking: #3823
Metadata Update from @jlanda: - Issue assigned to jlanda
Commit 8e3ae65 fixes this issue
Log in to comment on this ticket.